Merge pull request #185 from graphql-dotnet/develop

fix stack overflow in equality comparer
graphql-dotnet · Mar 9, 2020 · abf006d · abf006d
2 parents b5750ed + a727000
commit abf006d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/GraphQL.Primitives/GraphQLRequest.cs b/src/GraphQL.Primitives/GraphQLRequest.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Runtime.Serialization;
 
 namespace GraphQL {
@@ -64,7 +65,7 @@ public override bool Equals(object? obj) {
 		public virtual bool Equals(GraphQLRequest? other) {
 			if (ReferenceEquals(null, other)) return false;
 			if (ReferenceEquals(this, other)) return true;
-			return EqualityComparer<Dictionary<string,object>>.Default.Equals(this, other);
+			return this.Count == other.Count && !this.Except(other).Any();
 		}
 
 		/// <summary>