Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Altair GraphQL UI. #301

Merged
merged 2 commits into from
Jan 12, 2020
Merged

Added Altair GraphQL UI. #301

merged 2 commits into from
Jan 12, 2020

Conversation

imolorhe
Copy link
Contributor

Added Altair GraphQL Client as an alternative GraphQL UI tool.
Altair comes packed with a lot of useful features to make it easy to work with GraphQL, and would be very useful to a lot of developers.

@sungam3r
Copy link
Member

@imolorhe Thank you very much for your work. I just recently read about Altair and tried to use it as desktop standalone app. I am glad that it is possible to connect Altair as html page.

Note that you will have to add a new package to build scripts - https://github.com/graphql-dotnet/server/blob/develop/build.cake#L14

@sungam3r sungam3r added the enhancement New feature or request label Jan 12, 2020
@imolorhe
Copy link
Contributor Author

Note that you will have to add a new package to build scripts - https://github.com/graphql-dotnet/server/blob/develop/build.cake#L14

I already added the project here:

"./src/Ui.Altair/Ui.Altair.csproj",

Do I need to do something else?

@imolorhe
Copy link
Contributor Author

I just recently read about Altair and tried to use it as desktop standalone app.

I'm curious as to where you read about Altair for the first time? 🙂

@imolorhe
Copy link
Contributor Author

imolorhe commented Jan 12, 2020

I should also add that Altair comes with many more configuration options: https://github.com/imolorhe/altair#configuration-options

But I figured it's okay for the first PR not to have them (lesser code, faster review). Also would appreciate if some core contributor could add those options instead of myself.

@sungam3r
Copy link
Member

Do I need to do something else?

I overlooked it, everything is fine.

@sungam3r
Copy link
Member

I'm curious as to where you read about Altair for the first time?

graphql/graphql-over-http#48

@sungam3r
Copy link
Member

I should also add that Altair comes with many more configuration options

You may add link to https://github.com/imolorhe/altair#configuration-options for GraphQLAltairOptions summary comments.

@sungam3r sungam3r merged commit d42d56d into graphql-dotnet:develop Jan 12, 2020
@sungam3r
Copy link
Member

sungam3r commented Jan 12, 2020

@joemcbride @pekkah New package was uploaded to myget feed: https://ci.appveyor.com/project/graphql-dotnet-ci/server/builds/30054845#L558 but requires (as I understand) manual push to nuget. Please tell me, do I need any special keys / access rights for this?
изображение

@imolorhe imolorhe deleted the add-altair-graphql branch January 12, 2020 15:19
@imolorhe
Copy link
Contributor Author

Thanks @sungam3r!

I see that there is also docs for GraphiQL here: https://graphql-dotnet.github.io/docs/getting-started/graphiql

Would it make sense to add Altair to the docs as well?

@sungam3r
Copy link
Member

Of course.

@sungam3r sungam3r mentioned this pull request Jan 13, 2020
@imolorhe
Copy link
Contributor Author

@sungam3r Looks like the Altair package isn't still available.

@sungam3r
Copy link
Member

I know. @joemcbride could you please publish it?

rose-a pushed a commit to rose-a/server that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants