Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use new logo in emails #6501

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

egoodwinx
Copy link

@egoodwinx egoodwinx commented Feb 11, 2025

Background

Closes #6147

Description

Update to use new logo hosted on main website for emails. I couldn't get an email sent to me but tested in in web browser and it worked as expected. Increased size to 200px since its a bit small otherwise.

Checklist

  • Input validation
  • Output encoding
  • Authentication management
  • Session management
  • Access control
  • Cryptographic practices
  • Error handling and logging
  • Data protection
  • Communication security
  • System configuration
  • Database security
  • File management
  • Memory management
  • Testing

Copy link
Contributor

coderabbitai bot commented Feb 11, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Enhanced the visual appearance of email notifications by updating the logo image source and increasing the logo width from 150px to 200px across various communication templates.

Walkthrough

The pull request updates the MJML email templates in two service modules: AuditLogManager and OrganizationManager. The email templates now use a new image URL and an increased image width, changing from https://graphql-hive.com/logo.png with a width of 150px to https://the-guild.dev/graphql/hive/github-org-image.png with a width of 200px. These modifications affect only the visual presentation of the emails without altering the underlying functionality or control flow.

Changes

Files Change Summary
.../audit-logs-manager.ts
.../organization-manager.ts
Updated MJML email templates: replaced the image source URL from https://graphql-hive.com/logo.png to https://the-guild.dev/graphql/hive/github-org-image.png and increased the image width from 150px to 200px in their respective email methods.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 780efd7 and 2fe47a8.

📒 Files selected for processing (1)
  • packages/services/api/src/modules/organization/providers/organization-manager.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/services/api/src/modules/organization/providers/organization-manager.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -219,7 +219,7 @@ export class AuditLogManager {
<mj-body>
<mj-section>
<mj-column>
<mj-image width="150px" src="https://graphql-hive.com/logo.png"></mj-image>
<mj-image width="200px" src="https://the-guild.dev/graphql/hive/github-org-image.png"></mj-image>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that this image has very different dimensions. I think even 300px width would be reasonable.

@jdolle
Copy link
Collaborator

jdolle commented Feb 12, 2025

This looks good to me but we should wait for another to review.

@jdolle jdolle enabled auto-merge (squash) February 13, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

emails are using old logos
3 participants