Skip to content

Conversation

@dotansimha
Copy link
Member

@dotansimha dotansimha commented Oct 24, 2025

Closes #508

TODO

  • setup nice way to define env vars and their overrides
  • Define logger overrides
  • Define supergraph overrides (file/hive)
  • Define HTTP overrides
  • Remove existing config extractor
  • Fix printing of error message in cases where server fails to start and logger is not configured yet
  • graphiql disable/enable
  • hive supergraph poll interval
  • Fix CI
  • Update docs and README
  • Docs docs(router): added documentation for env vars console#7172

@dotansimha dotansimha requested a review from ardatan October 24, 2025 07:19
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

k6-benchmark results

     ✓ response code was 200
     ✓ no graphql errors
     ✓ valid response structure

     █ setup

     checks.........................: 100.00% ✓ 198240      ✗ 0    
     data_received..................: 5.8 GB  193 MB/s
     data_sent......................: 78 MB   2.6 MB/s
     http_req_blocked...............: avg=4.17µs  min=661ns   med=1.71µs  max=7.02ms   p(90)=2.65µs   p(95)=3.19µs  
     http_req_connecting............: avg=1.27µs  min=0s      med=0s      max=3.7ms    p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=22.22ms min=2.15ms  med=21.14ms max=146.45ms p(90)=30.55ms  p(95)=34.06ms 
       { expected_response:true }...: avg=22.22ms min=2.15ms  med=21.14ms max=146.45ms p(90)=30.55ms  p(95)=34.06ms 
     http_req_failed................: 0.00%   ✓ 0           ✗ 66100
     http_req_receiving.............: avg=177.8µs min=26.04µs med=41.62µs max=114.8ms  p(90)=100.18µs p(95)=451.83µs
     http_req_sending...............: avg=26.07µs min=5.98µs  med=11.15µs max=26.32ms  p(90)=18.23µs  p(95)=28.77µs 
     http_req_tls_handshaking.......: avg=0s      min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=22.01ms min=2.06ms  med=21ms    max=60.28ms  p(90)=30.28ms  p(95)=33.67ms 
     http_reqs......................: 66100   2198.505951/s
     iteration_duration.............: avg=22.69ms min=6.77ms  med=21.51ms max=268.06ms p(90)=31.02ms  p(95)=34.6ms  
     iterations.....................: 66080   2197.840745/s
     vus............................: 50      min=50        max=50 
     vus_max........................: 50      min=50        max=50 

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

🐋 This PR was built and pushed to the following Docker images:

Image Names: ghcr.io/graphql-hive/router

Platforms: linux/amd64,linux/arm64

Image Tags: ghcr.io/graphql-hive/router:pr-519 ghcr.io/graphql-hive/router:sha-c44925c

Docker metadata
{
"buildx.build.ref": "builder-c0ddf05d-848e-456d-aa33-1e7010463567/builder-c0ddf05d-848e-456d-aa33-1e70104635670/6f9gaqbehpljyck877iarz30y",
"containerimage.descriptor": {
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "digest": "sha256:9dc235c64d41d637eb485f7e6fdb603ae8e2697f58a7b649b6a8803aa6ad2e2c",
  "size": 1609
},
"containerimage.digest": "sha256:9dc235c64d41d637eb485f7e6fdb603ae8e2697f58a7b649b6a8803aa6ad2e2c",
"image.name": "ghcr.io/graphql-hive/router:pr-519,ghcr.io/graphql-hive/router:sha-c44925c"
}

@dotansimha dotansimha force-pushed the config-env-fixes branch 2 times, most recently from 0549d3a to f275f15 Compare October 26, 2025 13:20
@dotansimha dotansimha marked this pull request as ready for review October 26, 2025 13:45
@dotansimha dotansimha changed the title feat(config): configuration override using env vars feat(config): configuration override using env vars, enable/disable graphiql via config Oct 26, 2025
@kamilkisiela kamilkisiela merged commit b8f583c into main Oct 27, 2025
18 checks passed
@kamilkisiela kamilkisiela deleted the config-env-fixes branch October 27, 2025 09:02
This was referenced Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose specific configurations as env vars

3 participants