Refactor serde
and ScalarValue
relations
#985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #975
Synopsis
This PR refactors the way
serde
is paired withScalarValue
s. Previously,ScalarValue
exposedVisitor
associated type forInputValue<T>
being able to delegate scalar value deserialization,#[derive(GraphQLScalarValue)]
was always providing aSerialize
implementation. Such approach was causing issues for implementingScalarValue
for foreign types, because in mostde::Visitor
types are private and not exposed, which makes us to duplicate deserialization logic in our code, and user looses control over serialization.Solution
The refactored approach requires only
T: Deserialize
forimpl Deserialize for InputValue<T>
, and, additionally, removesimpl Serialize
from the code generated by#[derive(GraphQLScalarValue)]
. This allows:Deserialize
impls for foreign types and require to do squats with exposingVisitor
;Checklist