Add DynamoDB example #241
Open
Add DynamoDB example #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-nouri
reviewed
May 11, 2020
| region: AWS_REGION // aws region that the dynamodb table was created e.g. us-east-1 | ||
| }); | ||
|
|
||
| const movieLoader = new Dataloader(async ids => { |
There was a problem hiding this comment.
This will generate an error, batchGet expects a Set[] of keys, no duplicates, otherwise it will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to implement a dataloader with Amazon's DynamoDB and ran into some limitations on Dynamo's batch API and had to add some workarounds so I thought I'd share my implementation.
This PR provides a dataloader DynamoDB example that uses it batchGet API to get items from an official example dataset.