DO NOT MERGE: alternative state management RFC #2906

jonathanawesome · 2022-11-13T16:44:50Z

Tracking issue #2904

changeset-bot · 2022-11-13T16:44:53Z

⚠️ No Changeset found

Latest commit: 1d360ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2022-11-13T16:46:25Z

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

acao · 2022-11-21T07:48:10Z

Decided not to invite y’all as proper reviewers yet because it’s still WIP but @B2o5T and @thomasheyenbrock we feel that we can rework state management in a 2.x refactor to make the rest of the planned features and plugin API easier to build, and for more intelligent & efficient component rendering - what do you think?

TallTed · 2022-11-21T15:03:05Z

ladle/src/utils/testSchema.ts

+  new Promise(res => setTimeout(res, timeout));
+
+const longDescription = `
+The \`longDescriptionType\` field on the \`Test\` type has a long, verbose, description to test inline field docs.


Suggested change

The \`longDescriptionType\` field on the \`Test\` type has a long, verbose, description to test inline field docs.

The \`longDescriptionType\` field on the \`Test\` type has a long, verbose description to test inline field docs.

thomasheyenbrock

Love the idea of moving the doc explorer into its own plugin package! Aligns nicely with all the other plugins, both existing ones and future ones.

My main question here is if we can make this backwards compatible with the existing hooks from v2. In other words, can we keep exporting the ExplorerContext and the useExplorerContext hook while moving all the actual state management from the ExplorerContextProvider component into zustand?

I guess it would not require a major version bump for graphiql either way, but we should decide if we're fine with breaking stuff for folks that use @graphiql/react directly.

acao · 2022-11-26T12:34:50Z

@thomasheyenbrock yes this was part of the original plugin proposal in #1689 , the idea was that the plugin API should be able to support doc explorer, query history, etc as plugins!

also, @graphiql/react is still in 0.x state, so direct consumers will expect breaking changes over minor versions as per semver until we feel we have a stable API for 1.x (maybe that can be the goal for 3.0.x).

dimaMachina · 2022-12-02T11:48:08Z

ladle/yarn.lock

@@ -0,0 +1,4354 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


this lock file should be removed since you added laddle to workspace

dimaMachina · 2022-12-02T11:49:57Z

packages/graphiql-plugin-react-doc-explorer/.eslintrc

@@ -0,0 +1,22 @@
+{
+  "extends": [


Suggested change

"extends": [

"root": true,

"extends": [

this config do nothing, without root: true always root eslint config is taken in priority

dimaMachina · 2022-12-02T11:50:47Z

packages/graphiql-plugin-react-doc-explorer/src/components/DocExplorer/DocExplorer.tsx

+        <div className="graphiql-doc-explorer-header-content">
+          {prevName && (
+            <button
+              // href="#"


Suggested change

// href="#"

dimaMachina · 2022-12-02T11:53:09Z

ladle/.eslintrc

@@ -0,0 +1,19 @@
+{


Suggested change

{

{

"root": true,

same here

dimaMachina · 2022-12-02T11:54:50Z

ladle/.eslintrc

@@ -0,0 +1,19 @@
+{
+  "extends": [
+    "plugin:prettier/recommended", 


Suggested change

"plugin:prettier/recommended",

I don't like eslint-plugin-pretter since he make a lot of noise, anyway prettier check action is enabled in ci

dimaMachina · 2025-05-13T22:57:46Z

replaced by #3946, tracking progress in #3874

init ladle

b5ffb5c

jonathanawesome added rfc Request for Comment graphiql proposal feedback wanted @graphiql/react do not merge labels Nov 13, 2022

jonathanawesome added 12 commits November 13, 2022 13:51

sets ladle as a workspace

e28b900

get ladle running

d74aee8

update cspell config

029a341

update .eslintignore

007e35e

ladle config update, doc explorer -> plugin package

9e646d5

add GraphiQL stories

381d5b0

fix cspell issues

c3ea4bb

test commit for ladle stories/cspell issue

b561dd2

test commit2 to diagnose cspell failure

32596a7

test commit3 for diagnosing cspell/ladle issues

ce3dca4

test commit4 for diagnosing cspell/ladle issues

f4f3f17

cspell...y u being tough?

1d360ef

acao requested review from dimaMachina, thomasheyenbrock and imolorhe and removed request for imolorhe, dimaMachina and thomasheyenbrock November 21, 2022 07:27

TallTed reviewed Nov 21, 2022

View reviewed changes

thomasheyenbrock reviewed Nov 25, 2022

View reviewed changes

dimaMachina reviewed Dec 2, 2022

View reviewed changes

ladle/.eslintrc

@@ -0,0 +1,19 @@

{

Copy link

Collaborator

dimaMachina Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

{

{

"root": true,

same here

acao reacted with thumbs up emoji

dimaMachina reviewed Dec 2, 2022

View reviewed changes

acao marked this pull request as draft January 22, 2023 15:25

dimaMachina closed this May 13, 2025

dimaMachina deleted the rfc/migrate-from-react-context-to-zustand branch May 13, 2025 22:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DO NOT MERGE: alternative state management RFC #2906

DO NOT MERGE: alternative state management RFC #2906

Uh oh!

jonathanawesome commented Nov 13, 2022

Uh oh!

changeset-bot bot commented Nov 13, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Nov 13, 2022

Uh oh!

acao commented Nov 21, 2022

Uh oh!

TallTed Nov 21, 2022

Uh oh!

thomasheyenbrock left a comment

Uh oh!

acao commented Nov 26, 2022 •

edited

Loading

Uh oh!

dimaMachina Dec 2, 2022

Uh oh!

dimaMachina Dec 2, 2022

Uh oh!

dimaMachina Dec 2, 2022

Uh oh!

dimaMachina Dec 2, 2022

Uh oh!

dimaMachina Dec 2, 2022

Uh oh!

dimaMachina commented May 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

	The \`longDescriptionType\` field on the \`Test\` type has a long, verbose, description to test inline field docs.
	The \`longDescriptionType\` field on the \`Test\` type has a long, verbose description to test inline field docs.

		@@ -0,0 +1,4354 @@
		# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

DO NOT MERGE: alternative state management RFC #2906

DO NOT MERGE: alternative state management RFC #2906

Uh oh!

Conversation

jonathanawesome commented Nov 13, 2022

Uh oh!

changeset-bot bot commented Nov 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Nov 13, 2022

Uh oh!

acao commented Nov 21, 2022

Uh oh!

TallTed Nov 21, 2022

Choose a reason for hiding this comment

Uh oh!

thomasheyenbrock left a comment

Choose a reason for hiding this comment

Uh oh!

acao commented Nov 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimaMachina Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

dimaMachina Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

dimaMachina Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

dimaMachina Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

dimaMachina Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

dimaMachina commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Nov 13, 2022 •

edited

Loading

acao commented Nov 26, 2022 •

edited

Loading

dimaMachina commented May 13, 2025 •

edited

Loading