Skip to content

fix(buildSyncStreamItemQueue): fix early termination check timing #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(buildSyncStreamItemQueue): fix early termination check timing #4505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions src/execution/execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2655,19 +2655,7 @@ function buildSyncStreamItemQueue(

let iteration = iterator.next();
let currentIndex = initialIndex + 1;
let currentStreamItem:
| BoxedPromiseOrValue<StreamItemResult>
| (() => BoxedPromiseOrValue<StreamItemResult>) = firstStreamItem;
while (!iteration.done) {
// TODO: add test case for early sync termination
/* c8 ignore next 6 */
if (currentStreamItem instanceof BoxedPromiseOrValue) {
const result = currentStreamItem.value;
if (!isPromise(result) && result.item === undefined) {
break;
}
}

const itemPath = addPath(streamPath, currentIndex, undefined);

const value = iteration.value;
Expand All @@ -2683,11 +2671,18 @@ function buildSyncStreamItemQueue(
itemType,
);

currentStreamItem = enableEarlyExecution
? new BoxedPromiseOrValue(currentExecutor())
: () => new BoxedPromiseOrValue(currentExecutor());

streamItemQueue.push(currentStreamItem);
if (enableEarlyExecution) {
const currentStreamItem = new BoxedPromiseOrValue(currentExecutor());
const result = currentStreamItem.value;
streamItemQueue.push(currentStreamItem);
// TODO: add test case for early sync termination
/* c8 ignore next 3 */
if (!isPromise(result) && result.item === undefined) {
break;
}
} else {
streamItemQueue.push(() => new BoxedPromiseOrValue(currentExecutor()));
}

iteration = iterator.next();
currentIndex = initialIndex + 1;
Expand Down
Loading