Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve View Capture Implementation
This PR addresses several issues in the current view capture implementation, enhancing its accuracy, reliability, and performance across various view types.
Summary of Changes
Detailed Changes
ScrollView Height Calculation: Accurately calculates the full content height of ScrollViews, ensuring complete capture of scrollable content.
Forced Layout Measurement: Implements a pre-capture layout measurement to guarantee accurate view dimensions.
View Hierarchy Capture: Introduced a new
captureViewHierarchy
method for recursive processing of all view types, ensuring comprehensive capture of complex view structures.TextureView and SurfaceView Handling: Implemented dedicated capture methods for TextureView and SurfaceView, addressing their unique rendering characteristics.
Bitmap Scaling: Improved the scaling logic to maintain aspect ratio when resizing captured bitmaps.
Enhanced Logging: Added detailed logging throughout the capture process for easier debugging and issue identification.
Exception Handling: Strengthened exception handling, particularly for PixelCopy operations, improving the robustness of the capture process.
Testing Notes
Potential Impacts
Please review and test thoroughly. Any feedback or suggestions for further improvements are welcome.