Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DECaPS 3D Dust #62

Merged
merged 21 commits into from
Mar 4, 2025
Merged

DECaPS 3D Dust #62

merged 21 commits into from
Mar 4, 2025

Conversation

catherinezucker
Copy link
Contributor

This pull request implements the functionality to query the DECaPS 3D dust map of the southern Galactic plane.

dust maps.
return_flags (Optional[:obj:`bool`]): If :obj:`True`, then QA flags will be
returned in a second numpy structured array. That is, the query
will return :obj:`ret`, :obj:'flags`, where :obj:`ret` is the normal return
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change 'flags` to `flags`.

return ret, flags

return ret
@property
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert empty line above.

@gregreen
Copy link
Owner

gregreen commented Mar 4, 2025

I've left two small comments in decaps.py, noting small changes to be made. There are three additional changes that I see right now:

  1. Dustmaps has moved to dual-licensing. Please look at the other files in the latest master branch, and copy the copyright section from their headers into decaps.py (assuming you are okay with dual licensing).
  2. Remove (git rm) the two .DS_Store files.
  3. Add your fetch routine to setup.py.

Catherine Zucker Catherine Zucker and others added 3 commits March 3, 2025 23:28
@gregreen gregreen merged commit dc9ad61 into gregreen:master Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants