Add support for pool taints and labels #474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Waiting for API to be updated with the new field. Then I can run tests and do manual testing. |
Contributor
|
Hi @fabiante any updates on when this will make it into a release? |
Member
Author
|
This feature is generally released on GSK 1.32 - we are actively working on that and want to publish it next week. Once that happens, i will update and merge this PR to allow usage via Terraform too. |
fabiante
force-pushed
the
feat/gsk-taints
branch
from
a8c2678 to
dcc172d
Compare
fabiante
commented
Dec 2, 2025
fabiante
changed the title
fabiante
force-pushed
the
feat/gsk-taints
branch
from
399e6e6 to
b19464a
Compare
fabiante
commented
Dec 2, 2025
The API already does the validation. I don't want to copy the APIs regex into this project, because it will likely result in drift between the values.
Member
|
LGTM |
nvthongswansea
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #469