Upgrade Dependency connect-redis from 3.4.0 to 8.0.1 #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexaltation
added
dependencies
hexaltation
force-pushed
the
dependencies-update-connect-redis
branch
from
633d761 to
43adde8
Compare
hexaltation
changed the title
hexaltation
changed the title
hexaltation
force-pushed
the
dependencies-update-connect-redis
branch
from
eae178f to
17cf0dc
Compare
To work it needs at least: * bump redis from 3.1.1 to 4.5.7 * bump redislock from 3.1.2 to 5.0.0-beta.2 Some major breaking changes appears in this two packages. [Redis](https://www.npmjs.com/package/redis): * All methods now return promises natively - promesifyAll is no longer needed - Async Postfix needs to be removed everywhere * Types are now native - `RedisClientType` client is created onCreate() * SUBSCRIBE methode needsa listener * All Redis Commands need camelCase or CAPS * hmset is deprecated and needs to be replace by hSet [Redlock](https://www.npmjs.com/package/redlock): * Before 5.0.0 it only support [ioredis](https://www.npmjs.com/package/ioredis) implementation. AFAIK 5.0.0 implements support for [redis-node](https://www.npmjs.com/package/redis) Build fails on this commit Some type adaptations, and syntactic corrections still remains to be done.
hexaltation
force-pushed
the
dependencies-update-connect-redis
branch
from
17cf0dc to
ec019cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is a follow-up of #1368
It manage to upgrade redis-connect to it's latest release
Proposed solution
The following strategy has been chosen.
Bump connect-redis from 3.4.0 to 4.0.4
Applies migration following https://github.com/tj/connect-redis/blob/c951850eb72759f387d4ae0c249aca8e1e9fc244/migration-to-v4.md
Bump connect-redis from 4.0.4 to 7.1.1
Applies migration following https://github.com/tj/connect-redis/releases/tag/v7.0.0
As express-session is needed as a peer dependency, it as been explicitly added to grist-core dependencies.
A resolution has been added to resolve to
@gristlabs/express-session.Bump connect-redis from 7.1.1 to 8.0.1
Applies migration following https://github.com/tj/connect-redis/releases/tag/v8.0.0
Has this been tested?