Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiping through images in viewer widget #117

Merged
merged 29 commits into from
Feb 21, 2024

Conversation

JakubSerafin
Copy link
Contributor

Viewer widget will show buttons prev and next on top, when more that one url can be found in the cell.
Also, images can be swiped on mobile via gesture.

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
🔨 Latest commit 9d8a672
🔍 Latest deploy log https://app.netlify.com/sites/boisterous-sunburst-a5c941/deploys/65d377e2f83de10008a7e120
😎 Deploy Preview https://deploy-preview-117--boisterous-sunburst-a5c941.netlify.app/viewer
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@berhalak berhalak self-requested a review January 30, 2024 15:19
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good starting point, things that should be improved (in my opinion)

yarn.lock Outdated Show resolved Hide resolved
test/init-mocha-webdriver.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/fixtures/images/image1.jpg Outdated Show resolved Hide resolved
test/gristWebDriverUtils.ts Outdated Show resolved Hide resolved
viewer/script.js Outdated Show resolved Hide resolved
viewer/script.js Outdated Show resolved Hide resolved
viewer/script.js Outdated Show resolved Hide resolved
viewer/script.js Outdated Show resolved Hide resolved
viewer/script.js Outdated Show resolved Hide resolved
@JakubSerafin
Copy link
Contributor Author

It is good starting point, things that should be improved (in my opinion)

* Overall UI, currently it is not pretty, we can easly use any out of box MIT library https://linxtion.com/demo/react-image-gallery/

* The size of the window is wrong, I see scrollbars all the time.

Overall UI improved to be more similar to that in linxtion.
Cannot spot any scrollbar in chrome/firefox unix chrome, but added overlay handling anyway

@berhalak
Copy link
Contributor

When you switch rows from a row that has multiple images to a row with no images at all, those arrows are still there.

test/init-mocha-webdriver.ts Outdated Show resolved Hide resolved
test/gristWebDriverUtils.ts Outdated Show resolved Hide resolved
test/viewer.ts Outdated Show resolved Hide resolved
viewer/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@berhalak berhalak merged commit a1fb277 into master Feb 21, 2024
2 checks passed
@berhalak berhalak deleted the feature/image-viewer-multi-images branch February 21, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants