-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swiping through images in viewer widget #117
Conversation
✅ Deploy Preview for boisterous-sunburst-a5c941 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… and fix for alt tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good starting point, things that should be improved (in my opinion)
- Overall UI, currently it is not pretty, we can easly use any out of box MIT library https://linxtion.com/demo/react-image-gallery/
- The size of the window is wrong, I see scrollbars all the time.
Overall UI improved to be more similar to that in linxtion. |
When you switch rows from a row that has multiple images to a row with no images at all, those arrows are still there. |
…OnWidget replaced with selectSectionByTitle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Viewer widget will show buttons prev and next on top, when more that one url can be found in the cell.
Also, images can be swiped on mobile via gesture.