Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get set up for systematically testing custom widgets #51

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

paulfitz
Copy link
Member

@paulfitz paulfitz commented Jul 17, 2023

This is a start at a test harness for the grist-widget repo. The test/gristWebDriverUtils.ts file depends on a small refactor of grist-core (see gristlabs/grist-core#576). To exercise the harness, I wrote a small test for inspect and flashcards.

We have an embarrassment of riches in ways to have a Grist page to test with (grist-core, grist-electron, grist-static). I went with Grist in docker because it is most mature but am not committed to it.

The harness is a bit rough and ready in places - just making a start.

This is a draft of a test harness for the grist-widget repo.
The test/gristWebDriverUtils.ts depends on a small refactor
of grist-core.
@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
🔨 Latest commit 26ea939
🔍 Latest deploy log https://app.netlify.com/sites/boisterous-sunburst-a5c941/deploys/64b97f5914847a00087002fd
😎 Deploy Preview https://deploy-preview-51--boisterous-sunburst-a5c941.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paulfitz paulfitz marked this pull request as ready for review July 20, 2023 19:26
@georgegevoian georgegevoian self-requested a review July 21, 2023 00:31
Copy link
Contributor

@georgegevoian georgegevoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @paulfitz.

@paulfitz paulfitz merged commit d238275 into master Jul 25, 2023
@paulfitz paulfitz deleted the paulfitz/start-testing branch July 25, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants