Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom widget supporting memes template #54

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

paulfitz
Copy link
Member

This adds in a custom widget that was lying around in my personal fork, and got used to support a Grist template:

https://templates.getgrist.com/gtzQwTXkgzFG/Meme-Generator

It isn't great code but it works, so just adding it unchanged other than some comments and formatting. I occasionally zap my personal fork so it would be safer not to rely on it.

This adds in a custom widget that was lying around in my personal
fork, and got used to support a Grist template:

  https://templates.getgrist.com/gtzQwTXkgzFG/Meme-Generator

It isn't great code but it works, so just adding it unchanged
other than some comments and formatting. I occasionally zap my
personal fork so it would be safer not to rely on it.
@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
🔨 Latest commit 25ed8de
🔍 Latest deploy log https://app.netlify.com/sites/boisterous-sunburst-a5c941/deploys/64bff53273552c0008aba740
😎 Deploy Preview https://deploy-preview-54--boisterous-sunburst-a5c941.netlify.app/memes
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@paulfitz
Copy link
Member Author

Confirmed that forking the template and replacing the custom widget URL works.

Copy link
Contributor

@JakubSerafin JakubSerafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because "It isn't great code but it works, so just adding it unchanged other than some comments and formatting" i'm not focusing on code quality here. Code is understandable and it's enough :) thanks!

@paulfitz paulfitz merged commit 459a159 into master Jul 26, 2023
1 check passed
@paulfitz paulfitz deleted the paulfitz/memes branch July 26, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants