Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar widget #56
Calendar widget #56
Changes from 50 commits
41f6981
f739e37
86bd58c
9ee8531
3766351
c215ffa
c41bc49
c02a8b2
d6fdaa5
1a3b9b8
6b2a30c
9ab1af5
ad5065c
06fa897
ce02e71
8dd89c1
df8d4f7
4ea9d9a
06ff8e6
86a9a70
b85bedd
5fd4729
84d0b49
a2151b1
ae46dfc
dfbe568
bf57d15
4b62148
f2ebcf5
0d10535
a8ce80f
9effe1b
c7c8f2b
9efdf7a
ddbdb8a
2514dfe
269605c
7177773
302ca76
6a80bf5
a02880d
e51d004
06f7135
01b83fd
d7df3c7
a916f83
d282ac3
98f92c1
5b2708d
327a72d
114ce45
b711366
9341245
6c9a829
6906ae8
476612a
2ac80fa
453b3a2
85e3064
850d5c2
c407635
727e2cf
d5ec8de
301fb98
5918966
d71488b
e24c24a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm why do we need to refetch the record from the application? Can't we just update the start and end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was my first approach, but
TableOperations.update()
seems to nullify all fields that are absent in argument.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems bad, is this a bug in
TableOperations.update
? Fetching, patching and re-saving would leave any user of this api prone to races.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it was not a bug in
TableOperations.update
but rather specific way in withgrist.mapColumnNamesBack
works. It map back all fields that was in source object, but for absent fields it just put a "undefined" under the target object value for given key.It's up to discussion if
grist.mapColumnNamesBack
should work that wayThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on what
grist.mapColumnNamesBack
should do for absent fields @berhalak ?