Address review feedback: Array validation, chronological pruning, safe iterators, workflow perms #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 4 review comments from PR #26: inadequate API response validation, incorrect mention pruning order, unsafe iterator pattern, and missing workflow permissions causing CI failures.
Changes
Array.isArray() guard in fetchThread: Validates
response.datais actually an array before callingparseThread(), preventing crashes on unexpected API shapesChronological pruning order: Process mentions oldest→newest (reverse iteration) so Set insertion order matches time order. Since X API returns
[newest, ..., oldest], forward iteration caused pruning to delete newest mentions instead of oldestSafe iterator pattern: Replace
iter.next().value as stringwith destructured{ value, done }check to avoid silent undefined on exhausted iterationWorkflow permissions: Add
pull-requests: writeto.github/workflows/pr-checks.ymlto fix "Resource not accessible by integration" error when posting validation comments💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.