fix: implement actionable review feedback from pending PRs #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidates unresolved review feedback from PRs #4, #13, #25, and #26 into a single PR. Fixes runtime bugs, type safety issues, workflow permission failures, and missing documentation.
Motivation
19 open PRs had accumulated actionable review comments that were never addressed. This PR implements the concrete suggestions to unblock merging.
Changes
TypeScript runtime fixes (PR #26 feedback):
src/services/xapi.ts: UseURLSearchParamsinstead of string concatenation, addsince_idpagination, addArray.isArray()guard infetchThread, useunknownoveranyinparseThread, avoid mutating sort with spreadsrc/index.ts: Addconsole.log→stderrredirect for MCP StdioServerTransport, useunknown[]notany[]src/services/agent.ts: Add boundedprocessedMentionspruning (10k cap) with safe{ value, done }iterator, process mentions oldest-first for correct chronological evictionWorkflow fixes (PR #13 feedback):
permissionsblocks to all three workflows (pull-requests: write,issues: write)auto-label.yml: Switch topull_request_targetfor fork PR supportissue-triage.yml: Check labels exist before adding to avoid 422 errorsDocumentation (PR #25 feedback):
CONTRIBUTING.md,.github/PR_TITLE_GUIDE.md,.github/pull_request_template.mdREADME.mdwith absolute paths per review suggestionCODEOWNERS (PR #4 feedback):
@codex,@Vercel,@Claude,@Copilot) with@groupthinkingRelated Issues
Addresses review feedback from PRs #4, #6, #13, #25, #26
Testing
npm run build)Checklist
feat:,fix:,docs:)Screenshots / Logs (if applicable)
CodeQL scan: 0 alerts across actions, Python, and JavaScript.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.