Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

Multiple open PRs have accumulated actionable but unimplemented review feedback. This PR addresses all unresolved comments in a single changeset to unblock clearing the backlog.

API robustness (src/services/xapi.ts)

  • URLSearchParams for mentions endpoint — replaces fragile string concatenation, adds since_id support when lastMentionId is set
  • Array.isArray guard before parseThread — prevents crash when API returns non-array data
  • Typed parseThread parameterany[]{ created_at: string; [key: string]: unknown }[]
// Before
return this.parseThread(response.data || []);

// After
if (!Array.isArray(response.data)) {
  console.warn('Unexpected response shape from X API (thread): data is not an array');
  return null;
}
return this.parseThread(response.data);

Type safety (src/services/grok.ts)

  • Replace const data: any with unknown + runtime structure validation before narrowing to typed access

Workflow fix (auto-label.yml)

  • Remove duplicate with: key — this was a YAML parse error causing the auto-label workflow to fail on every trigger

Docs (README.md)

  • Fix &and for readability
  • Fix broken ordered list (. Visit1. Visit)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Implement suggestions and correct errors in pending PRs fix: consolidate unresolved review feedback from PRs #4, #6, #13, #26 Feb 9, 2026
Copilot AI requested a review from groupthinking February 9, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants