fix: address unresolved review feedback — Array.isArray guard, URLSearchParams, type safety

src/services/grok.ts

@@ -58,7 +58,10 @@ export class GrokService {
         throw new Error(`Grok API error: ${response.status}`);
       }
 
-      const data: any = await response.json();
+      const data = await response.json() as { choices?: Array<{ message?: { content?: string } }> };
+      if (!Array.isArray(data.choices)) {
+        throw new Error('Unexpected Grok API response: missing choices array');
+      }
       const analysisText = data.choices[0]?.message?.content || '';
 
       // Use the root post ID from the thread, not the mention text
@@ -113,9 +116,14 @@ export class GrokService {
       }
 
       const parsed = JSON.parse(jsonMatch[0]);
-
+
+      const validActions: AgentAction['type'][] = ['reply', 'search', 'generate', 'analyze'];
+      const actionType: AgentAction['type'] = validActions.includes(parsed.action)
+        ? parsed.action
+        : 'analyze';
+
       const action: AgentAction = {
-        type: parsed.action as any,
+        type: actionType,
         target_post_id: mentionPostId,
         content: parsed.content,
         query: parsed.action === 'search' ? parsed.content : undefined,

src/services/xapi.ts

@@ -44,10 +44,13 @@ export class XAPIClient {
         throw new Error('Failed to get user ID from response');
       }
 
-      const mentionsResponse = await this.makeXAPIRequest(
-        `https://api.twitter.com/2/users/${userId}/mentions?max_results=10&expansions=author_id&tweet.fields=created_at,conversation_id,in_reply_to_user_id,referenced_tweets`,
-        'GET'
-      );
+      const params = new URLSearchParams({
+        max_results: '10',
+        expansions: 'author_id',
+        'tweet.fields': 'created_at,conversation_id,in_reply_to_user_id,referenced_tweets',
+      });
+      const mentionsUrl = `https://api.twitter.com/2/users/${userId}/mentions?${params.toString()}`;
+      const mentionsResponse = await this.makeXAPIRequest(mentionsUrl, 'GET');
 
       if (!mentionsResponse || !Array.isArray(mentionsResponse.data)) {
         console.warn('Invalid response from X API (mentions)');
@@ -77,7 +80,11 @@ export class XAPIClient {
         'GET'
       );
 
-      return this.parseThread(response.data || []);
+      if (!Array.isArray(response.data)) {
+        console.warn('Unexpected response shape from X API (thread): data is not an array');
+        return null;
+      }
+      return this.parseThread(response.data);
     } catch (error) {
       console.error('Error fetching thread:', error);
       return null;