Skip to content

Fix 6 critical security vulnerabilities: replace pickle with JSON, MD5 with SHA-256, remove hardcoded credentials #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
groupthinking merged 3 commits into from
Jul 8, 2025
Merged

Fix 6 critical security vulnerabilities: replace pickle with JSON, MD5 with SHA-256, remove hardcoded credentials #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daac28f
Initial plan
Copilot Jul 7, 2025
6d05890
Fix 6 security vulnerabilities: replace pickle with JSON, MD5 with SH…
Copilot Jul 7, 2025
12c0eab
Merge branch 'master' into copilot/fix-213aa9e3-0b23-4bd9-9b0c-2eb2bc…
groupthinking Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions connectors/mcp_debug_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
copilot/fix-94a3a2ef-451e-4b72-9782-aff6506fa546
import traceback
import os
copilot/fix-213aa9e3-0b23-4bd9-9b0c-2eb2bc585c94
=======
=======
master
master
from datetime import datetime, timezone
from typing import Dict, Any, Optional, List
Expand Down
16 changes: 15 additions & 1 deletion llm/continuous_learning_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,10 +597,14 @@ async def _create_model_version(
training_data_size=self.training_stats["total_samples_processed"],
quantum_optimized=self.quantum_connector.connected,
file_path=str(self.model_dir / f"{version_id}.json"),
copilot/fix-213aa9e3-0b23-4bd9-9b0c-2eb2bc585c94
checksum=hashlib.sha256(version_id.encode()).hexdigest(),

copilot/fix-94a3a2ef-451e-4b72-9782-aff6506fa546
checksum=hashlib.sha256(version_id.encode()).hexdigest(),
=======

checksum=hashlib.md5(version_id.encode()).hexdigest(),
master
master
)

Expand All @@ -611,12 +615,17 @@ async def _create_model_version(
"model_state": "simulated_model_state",
}

copilot/fix-213aa9e3-0b23-4bd9-9b0c-2eb2bc585c94
with open(version.file_path, "w") as f:
json.dump(model_data, f, indent=2, default=str)

copilot/fix-94a3a2ef-451e-4b72-9782-aff6506fa546
with open(version.file_path, "w") as f:
json.dump(model_data, f, indent=2, default=str)

with open(version.file_path, "w", encoding="utf-8") as f:
json.dump(model_data, f, cls=ModelVersionJSONEncoder, indent=2)
master
master

# Update current version
Expand Down Expand Up @@ -666,13 +675,18 @@ async def _load_or_create_model(self):
json_files = list(self.model_dir.glob("*.json"))
pkl_files = list(self.model_dir.glob("*.pkl"))

copilot/fix-213aa9e3-0b23-4bd9-9b0c-2eb2bc585c94
with open(latest_file, "r") as f:
model_data = json.load(f)

if json_files:
# Load latest JSON version
latest_file = max(json_files, key=lambda f: f.stat().st_mtime)
master

with open(latest_file, "r", encoding="utf-8") as f:
model_data = json.load(f, cls=ModelVersionJSONDecoder)
master

self.current_model_version = model_data["version_info"]
logger.info(
Expand Down
Loading