Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: introduce generic xds clients xDS and LRS Client API signatures #8042

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

changed to decoder struct

e0a5652
Select commit
Loading
Failed to load commit list.
Open

xds: introduce generic xds clients xDS and LRS Client API signatures #8042

changed to decoder struct
e0a5652
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 11, 2025 in 0s

82.01% (-0.14%) compared to e95a4b7

View this Pull Request on Codecov

82.01% (-0.14%) compared to e95a4b7

Details

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (e95a4b7) to head (e0a5652).

Files with missing lines Patch % Lines
xds/internal/clients/xdsclient/client.go 0.00% 8 Missing ⚠️
xds/internal/clients/lrsclient/client.go 0.00% 4 Missing ⚠️
xds/internal/clients/lrsclient/load_store.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8042      +/-   ##
==========================================
- Coverage   82.15%   82.01%   -0.14%     
==========================================
  Files         387      390       +3     
  Lines       39067    39081      +14     
==========================================
- Hits        32094    32051      -43     
- Misses       5643     5688      +45     
- Partials     1330     1342      +12     
Files with missing lines Coverage Δ
xds/internal/clients/config.go 97.61% <ø> (+4.43%) ⬆️
xds/internal/clients/lrsclient/client.go 0.00% <0.00%> (ø)
xds/internal/clients/lrsclient/load_store.go 0.00% <0.00%> (ø)
xds/internal/clients/xdsclient/client.go 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes