-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: export context errors #8241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export context errors #8241
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8241 +/- ##
==========================================
+ Coverage 82.09% 82.19% +0.09%
==========================================
Files 412 412
Lines 40491 40503 +12
==========================================
+ Hits 33242 33291 +49
+ Misses 5876 5848 -28
+ Partials 1373 1364 -9
🚀 New features to boost your workflow:
|
Since grpc#6862 was closed as wontfix, this is a follow-up proposal to actuall pass along errors the caller may be interested it. The current wrapped errors are only used for the specific cases of context cancellation and deadline. The rationale being: these are the errors that are caused via passed in context arguments from the caller.
c0a3007
to
0233fb6
Compare
There were 3 issues mentioned in the previously closed issue: #6862 (comment)
For 1 & 2, the error types modified in the PR are only used for client side context cancellation, so we should be good. For 3, the client would still see status DEADLINE_EXCEEDED with the message set here, which would probably give a nil error on unwrapping: grpc-go/internal/transport/http2_client.go Lines 1238 to 1245 in 732f3f3
@dfawley would like to get your thoughts on this since you handled #6862. |
@arjan-bal thanks for the summary! Yes, the intention was to side-step the issues mentioned in the previous PR. |
It would be better if you could follow the standard feature request issue template instead of creating a PR (https://github.com/grpc/grpc-go/issues/new?template=feature.md). Specifically, what problem are you attempting to solve by this? |
Since #6862 was closed as wontfix, this is a follow-up proposal to actuall pass along errors the caller may be interested it.
The current wrapped errors are only used for the specific cases of context cancellation and deadline. The rationale being: these are the errors that are caused via passed in context arguments from the caller.