-
Notifications
You must be signed in to change notification settings - Fork 4.7k
xds: add internal ResourceNameFunc server option #9288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ran-su
wants to merge
9
commits into
grpc:master
Choose a base branch
from
ran-su:xds-server-resource-name-func
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+192
−42
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9a82435
xds: add ResourceNameFunc server option and UnderlyingServer method
ran-su 4f31647
xds: make ResourceNameFunc an internal option
ran-su 46297f0
xds: remove UnderlyingServer
ran-su 712d7fc
xds: address listener resource name review comments
ran-su c1b3cdf
simplify listener resource name override option
ran-su 4ecb9f6
xds: unify server option handling
ran-su fc81b5e
xds: fix server options lint naming
ran-su 6141a4e
update OverrideListenerResourceName document and simplify the test
ran-su 12f67c6
improve listener resource name test
ran-su File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * | ||
| * Copyright 2026 gRPC authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package server | ||
|
|
||
| import ( | ||
| "net" | ||
|
|
||
| "google.golang.org/grpc" | ||
| "google.golang.org/grpc/internal/xds/xdsclient" | ||
| ) | ||
|
|
||
| // Options contains options used by an xDS-enabled gRPC server. | ||
| // | ||
| // This type is internal so that the public xds package can expose server | ||
| // options without also owning their application and storage. | ||
| type Options struct { | ||
| ModeCallback ServingModeCallback | ||
| ClientPoolForTesting *xdsclient.Pool | ||
| OverrideListenerResourceName func(net.Addr) string | ||
| } | ||
|
|
||
| type serverOption struct { | ||
| grpc.EmptyServerOption | ||
| apply func(*Options) | ||
| } | ||
|
|
||
| // NewServerOption returns a grpc.ServerOption which applies f to the internal | ||
| // xDS server options. | ||
| func NewServerOption(f func(*Options)) grpc.ServerOption { | ||
| return &serverOption{apply: f} | ||
| } | ||
|
|
||
| // ApplyServerOptions applies all internal xDS server options in opts to so. | ||
| func ApplyServerOptions(opts []grpc.ServerOption, so *Options) { | ||
| for _, opt := range opts { | ||
| if o, ok := opt.(*serverOption); ok { | ||
| o.apply(so) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // OverrideListenerResourceName returns a server option that overrides the LDS | ||
| // resource name selected for an xDS server listener. The supplied function is | ||
| // called by Serve with the address returned by the listener's Addr method, and | ||
| // its return value is used as-is as the LDS listener resource name. | ||
| // | ||
| // The function is called once for each Serve invocation that gets past listener | ||
| // validation and the server-stopped check. If Serve is called concurrently, the | ||
| // function may be called concurrently and must be safe for concurrent use. | ||
| func OverrideListenerResourceName(f func(net.Addr) string) grpc.ServerOption { | ||
| return NewServerOption(func(o *Options) { | ||
| o.OverrideListenerResourceName = f | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.