Skip to content

[Security] Supporting negotiation of certs based on signing algorithm - #9321

Open
gtcooke94 wants to merge 3 commits into
grpc:masterfrom
gtcooke94:multiple_cert_support
Open

[Security] Supporting negotiation of certs based on signing algorithm#9321
gtcooke94 wants to merge 3 commits into
grpc:masterfrom
gtcooke94:multiple_cert_support

Conversation

@gtcooke94

@gtcooke94 gtcooke94 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This PR fixes issues where gRPC-Go would not correctly support the negotiation of certs based on signing algorithm when multiple are provided. There is no API change.

In advancedtls.go and sni.go, we now call buildGetCertificates unconditionally as this is where we select the certificate based on the desired SNI and signature algorithm.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.10%. Comparing base (1ecbd86) to head (0069064).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9321      +/-   ##
==========================================
- Coverage   83.11%   83.10%   -0.02%     
==========================================
  Files         423      423              
  Lines       35231    35236       +5     
==========================================
- Hits        29284    29283       -1     
- Misses       4432     4442      +10     
+ Partials     1515     1511       -4     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@easwars

easwars commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@gtcooke94 : Could you please get someone from the security team to review this before the grpc team starts looking at this.

Also, is there a gRFC/design that could be linked in the PR description. It is currently quite empty.

@easwars easwars added Type: Feature New features or improvements in behavior Type: Security A bug or other problem affecting security labels Aug 17, 2026
@easwars easwars added this to the 1.84 Release milestone Aug 17, 2026
@gtcooke94

gtcooke94 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Will get the security team to review soon once I finalize a few items

There's no public API change for this, but it's pre-work for post-quantum authenticity support. In fact, it's more of a bug in how we were handling things before, it's just that the use-case of negotiating the signature algorithm was never really used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New features or improvements in behavior Type: Security A bug or other problem affecting security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants