[Security] Supporting negotiation of certs based on signing algorithm - #9321
Open
gtcooke94 wants to merge 3 commits into
Open
[Security] Supporting negotiation of certs based on signing algorithm#9321gtcooke94 wants to merge 3 commits into
gtcooke94 wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9321 +/- ##
==========================================
- Coverage 83.11% 83.10% -0.02%
==========================================
Files 423 423
Lines 35231 35236 +5
==========================================
- Hits 29284 29283 -1
- Misses 4432 4442 +10
+ Partials 1515 1511 -4 🚀 New features to boost your workflow:
|
Contributor
|
@gtcooke94 : Could you please get someone from the security team to review this before the grpc team starts looking at this. Also, is there a gRFC/design that could be linked in the PR description. It is currently quite empty. |
Contributor
Author
|
Will get the security team to review soon once I finalize a few items There's no public API change for this, but it's pre-work for post-quantum authenticity support. In fact, it's more of a bug in how we were handling things before, it's just that the use-case of negotiating the signature algorithm was never really used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues where gRPC-Go would not correctly support the negotiation of certs based on signing algorithm when multiple are provided. There is no API change.
In advancedtls.go and sni.go, we now call
buildGetCertificatesunconditionally as this is where we select the certificate based on the desired SNI and signature algorithm.