Skip to content

server: remove code to suppress duplicate writing of status - #9322

Merged
easwars merged 1 commit into
grpc:masterfrom
easwars:remove_write_status_suppression
Aug 18, 2026
Merged

server: remove code to suppress duplicate writing of status#9322
easwars merged 1 commit into
grpc:masterfrom
easwars:remove_write_status_suppression

Conversation

@easwars

@easwars easwars commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Follow-up from #9309.

The transport currently handles duplicate status write suppression. There is no need to add a further check in the gRPC layer without having an explicit reason for it. Maybe there is some edge case that requires it. So, removing it.

RELEASE NOTES: none

@easwars
easwars requested a review from dfawley August 14, 2026 20:37
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Aug 14, 2026
@easwars easwars added this to the 1.84 Release milestone Aug 14, 2026
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.09%. Comparing base (bf9e7cd) to head (e944480).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9322      +/-   ##
==========================================
+ Coverage   83.07%   83.09%   +0.02%     
==========================================
  Files         423      423              
  Lines       35230    35226       -4     
==========================================
+ Hits        29266    29272       +6     
+ Misses       4448     4444       -4     
+ Partials     1516     1510       -6     
Files with missing lines Coverage Δ
server.go 83.55% <100.00%> (+0.11%) ⬆️
stream.go 84.16% <100.00%> (+0.37%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshitachandwani eshitachandwani assigned easwars and unassigned dfawley Aug 18, 2026
@easwars
easwars merged commit c92e985 into grpc:master Aug 18, 2026
21 of 23 checks passed
@easwars
easwars deleted the remove_write_status_suppression branch August 18, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants