Repository navigation
transport: prevent nil pointer dereference in recvBuffer.put. - #9533
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9533 +/- ##
==========================================
+ Coverage 87.76% 87.81% +0.04%
==========================================
Files 437 437
Lines 31406 31407 +1
==========================================
+ Hits 27565 27579 +14
+ Misses 3841 3828 -13
🚀 New features to boost your workflow:
|
easwars
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
b.erris already set on arecvBuffer,put()drops every laterrecvMsgand frees its buffer by callingr.buffer.Free(). ArecvMsgthat carries only an error orio.EOFhas no payload, so itsbufferis nil, and theFree()call panics with a nil pointer dereference.This change adds a nil check before calling r.buffer.Free() and adds an end-to-end test covering this scenario.
RELEASE NOTES: