Skip to content

Commit cde3d48

Browse files
author
j_y_.kim
committed
servlet: Add comment explaining workaround for issue #12540
1 parent 7272a28 commit cde3d48

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

servlet/src/tomcatTest/java/io/grpc/servlet/TomcatTransportTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ public void start(ServerListener listener) throws IOException {
9393
.setAsyncSupported(true);
9494
ctx.addServletMappingDecoded("/*", "TomcatTransportTest");
9595
tomcatServer.getConnector().addUpgradeProtocol(new Http2Protocol());
96+
// Workaround for https://github.com/grpc/grpc-java/issues/12540
97+
// Prevent premature OutputBuffer recycling by disabling facade recycling.
98+
// This should be revisited once the root cause is fixed.
9699
tomcatServer.getConnector().setDiscardFacades(false);
97100
try {
98101
tomcatServer.start();

0 commit comments

Comments
 (0)