Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PickFirstLeafLoadBalancer to only have 1 subchannel at a time #11520

Merged
merged 11 commits into from
Oct 3, 2024
Merged

Change PickFirstLeafLoadBalancer to only have 1 subchannel at a time #11520

merged 11 commits into from
Oct 3, 2024

Commits on Sep 26, 2024

  1. Change PickFirstLeafLoadBalancer to only have 1 subchannel at a time … 

    …if environment variable GRPC_SERIALIZE_RETRIES == true.

Cache serializingRetries value so that it doesn't have to look up the flag every time.

Clear the correct task when READY in processSubchannelState and move the logic to cancelScheduledTasks

Cleanup based on PR review

remove unneeded checks for shutdown.
    @larry-safran
    larry-safran committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0c70fd5 View commit details
    Browse the repository at this point in the history

  2. Fix previously broken tests

    @larry-safran
    larry-safran committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2658447 View commit details
    Browse the repository at this point in the history

  3. Fix previously broken tests

    @larry-safran
    larry-safran committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bd5f66f View commit details
    Browse the repository at this point in the history

  4. Shutdown previous subchannel when run off end of index.

    @larry-safran
    larry-safran committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bced263 View commit details
    Browse the repository at this point in the history

  5. Provide option to disable subchannel retries to let PFLeafLB take con… 

    …trol of retries.
    @larry-safran
    larry-safran committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3f910b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. InternalSubchannel internally goes to IDLE when sees TF when reconnec… 

    …t is disabled.

Remove an extra index.increment in LeafLB
Fix spelling, remove unneeded additions
    @larry-safran
    larry-safran committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f21b749 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Make errorprone happy

    @larry-safran
    larry-safran committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d50acf8 View commit details
    Browse the repository at this point in the history

  2. Make checkstyle happy

    @larry-safran
    larry-safran committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0b6e846 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Fix the other spelling mistake

    @larry-safran
    larry-safran committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b1ff88d View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Cleanup

    @larry-safran
    larry-safran committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e854c20 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Remove unneeded optimization

    @larry-safran
    larry-safran committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a28b548 View commit details
    Browse the repository at this point in the history