Implement ContextStorageOverride for opentelemetry context bridge #11523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Sep 16, 2024
contextstorage/src/main/java/io/grpc/override/OpenTelemetryContextStorage.java
Outdated
Show resolved
Hide resolved
| public Context current() { | ||
| io.opentelemetry.context.Context otelCurrent = io.opentelemetry.context.Context.current(); | ||
| io.grpc.Context grpcCurrent = otelCurrent.get(GRPC_CONTEXT_OVER_OTEL); | ||
| if (grpcCurrent == null) { |
There was a problem hiding this comment.
FYI: you could use Context.keyWithDefault("blah", Context.Root) to let the API handle this for you.
There was a problem hiding this comment.
hm, this only works for io.opentelemetry.context.keyWithDefault but they don't have this convenient API.
settings.gradle
Outdated
| @@ -76,6 +76,7 @@ include ":grpc-istio-interop-testing" | |||
| include ":grpc-inprocess" | |||
| include ":grpc-util" | |||
| include ":grpc-opentelemetry" | |||
| include ":grpc-context-storage-override" | |||
There was a problem hiding this comment.
The name of the package is clearly io.grpc.context-related. However, nothing speaks to "otel" in the name. context-opentelementry-storage (+override?) as the name? (context-storage-override-opentelemetry?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/357892637
follow up with #11500
opencensus shim will find opentelmetry context when using opencensus {@link io.opencensus.trace.unsafe.ContextManagerImpl}, but does not solve the problem of bridging io.grpc.context and io.opentelemetry.context
otel implementation does not have otel over grpc contxt:
https://github.com/open-telemetry/opentelemetry-java/blob/18d192d1fadc6f6dd4dfbff01c0c139eaf93c604/context/src/grpcInOtelTest/java/io/grpc/override/ContextStorageOverride.java
other implementation:
https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/grpc-1.6/library#library-instrumentation-for-grpc-160