s2a,netty: S2AHandshakerServiceChannel doesn't use custom event loop. #11539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta19
commented
Sep 19, 2024
netty/src/main/java/io/grpc/netty/InternalProtocolNegotiators.java
Outdated
Show resolved
Hide resolved
rmehta19
force-pushed
the
s2a-handshaker-default-event-loop
branch
from
03ced73
to
a8120bb
Compare
rmehta19
changed the title
matthewstevenson88
approved these changes
Sep 19, 2024
| } catch (InterruptedException e) { | ||
| isDelegateTerminated = false; | ||
| Thread.currentThread().interrupt(); |
There was a problem hiding this comment.
if shutdownNow didn't complete, you'll probably want to know about it for debugging, so I'd suggest logging a warning here.
ejona86
reviewed
Sep 19, 2024
s2a/src/main/java/io/grpc/s2a/handshaker/S2AProtocolNegotiatorFactory.java
Outdated
Show resolved
Hide resolved
rmehta19
force-pushed
the
s2a-handshaker-default-event-loop
branch
from
ba02591
to
653ac1e
Compare
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Sep 20, 2024
| */ | ||
| @VisibleForTesting | ||
| static class EventLoopHoldingChannel extends Channel { | ||
| static class HandshakerServiceChannel extends Channel { |
There was a problem hiding this comment.
ChannelResource doesn't need this class any longer. Delete it. (If you want to do it in a follow-up, that's fine.)
ejona86
approved these changes
Sep 20, 2024
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Merged
larry-safran
approved these changes
Sep 20, 2024
kannanjgithub
pushed a commit
to kannanjgithub/grpc-java
that referenced
this pull request
Oct 23, 2024
…grpc#11539) * S2AHandshakerServiceChannel doesn't use custom event loop. * use executorPool. * log when channel not shutdown. * use a cached threadpool. * update non-executor version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11113 (comment) and #11113 (comment)