Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2a: Address minor comments on PR#11113 #11540

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

s2a: Address minor comments on PR#11113 #11540

wants to merge 11 commits into from
+345 −285

Commits on Sep 19, 2024

  1. Use StandardCharsets in FakeS2AServerTest.

    @rmehta19
    rmehta19 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e3f3413 View commit details
    Browse the repository at this point in the history

  2. Use add instead of offer in S2AStub.

    @rmehta19
    rmehta19 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d13bd88 View commit details
    Browse the repository at this point in the history

  3. remove dead code in ProtoUtil.java.

    @rmehta19
    rmehta19 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    577b4e5 View commit details
    Browse the repository at this point in the history

  4. Mark convertTlsProtocolVersion as VisibleForTesting.

    @rmehta19
    rmehta19 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    59573ec View commit details
    Browse the repository at this point in the history

  5. S2AStub doesn't return responses at front of queue.

    @rmehta19
    rmehta19 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9efaa6a View commit details
    Browse the repository at this point in the history

  6. Remove global SHARED_RESOURCE_CHANNELS.

    @rmehta19
    rmehta19 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    df413b1 View commit details
    Browse the repository at this point in the history

  7. Don't suppress RethrowReflectiveOperationExceptionAsLinkageError.

    @rmehta19
    rmehta19 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    81ea900 View commit details
    Browse the repository at this point in the history

  8. Update javadoc.

    @rmehta19
    rmehta19 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d46e56d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Make clear which certs are used in tests + add how to regenerate.

    @rmehta19
    rmehta19 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    19b8f21 View commit details
    Browse the repository at this point in the history

  2. resolve merge conflict.

    @rmehta19
    rmehta19 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4af75f5 View commit details
    Browse the repository at this point in the history

  3. resolve merge conflict.

    @rmehta19
    rmehta19 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ea7b780 View commit details
    Browse the repository at this point in the history