-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize number of buffer allocations #11879
Open
panchenko
wants to merge
12
commits into
grpc:master
Choose a base branch
from
panchenko:okhttp-remove-4096
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−35
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
12d2f41
okhttp: remove 4096 min buffer size
panchenko caaac1e
Merge branch 'master' into okhttp-remove-4096
panchenko 8283b17
optimize number of buffer allocations
panchenko f8667f2
round up in okhttp
panchenko 6f04325
changes in OkHttpWritableBufferAllocator
panchenko d11b421
defautl method for tests
panchenko 40b7fc7
fix OkHttpWritableBufferAllocatorTest
panchenko 91c18ef
fix netty
panchenko 873ea3b
simplify params() in CompressionTest
panchenko 5ab225a
revert COMPRESSION_MIN_LENGTH
panchenko 4f7a5e4
call allocateKnownLength in netty
panchenko 0a3284e
test round up for okhttp
panchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okio Buffer works quite differently than Netty. Okio uses Segments that are all the same size and then combines adjacent buffers to avoid excessive internal fragmentation. We should leave this in-place and actually set it to 8192.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(If we were more serious, we'd round up:
(capacityHint + 8191) / 8192 * 8192
.)