add "resource_timer_is_transient_failure" server feature #12063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaspeaks
changed the title
ejona86
reviewed
May 29, 2025
| for (ResourceWatcher<T> watcher : watchers.keySet()) { | ||
| if (processingTracker != null) { | ||
| processingTracker.startTask(); | ||
| } | ||
| watchers.get(watcher).execute(() -> { | ||
| try { | ||
| /*This will go after xdsClient watcher APIs are in. | ||
| watcher.onResourceChanged(StatusOr.fromStatus(Status.UNAVAILABLE.withDescription( |
There was a problem hiding this comment.
We can just call onError(). That's equivalent for the current API as there is no data yet.
There was a problem hiding this comment.
I see a lot of new code has been merged since then. There are a lot of new failures in files like CdsLoadBalancer2Test, GrpcXdsClientImplTestBase, GrpcXdsClientImplV3Test, etc.
Same files and lines were also getting changed in xds client watcher API changes. Perhaps this should wait until xds client watcher api changes goes in?
There was a problem hiding this comment.
Why should there be any new failures? Sounds like you aren't setting resourceTimerIsTransientError correctly to preserve the old behavior for the majority of the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.