xds: Revert CdsLb to XdsDepManager, and follow-up commits (v1.74.x) #12216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannanjgithub
approved these changes
Jul 15, 2025
This reverts commit 297ab05. b/430347751 shows multiple concerning behaviors in the xDS stack with the new A74 config update model. XdsDepManager and CdsLB2 still seem to be working correctly, but the change is exacerbated issues in other parts of the stack, like RingHashConfig not having equals fixed in a8de9f0. Revert only for the v1.74.x release, leaving it on master.
ejona86
force-pushed
the
revert-cds-depman
branch
from
2608e4a to
61da156
Compare
|
I added 'Revert "Fix RLS regressions from XdsDepMan conversion"' as the first commit, thus all the others appears new even though they are the same content. The RLS regression fixes had been missing from my local sync of v1.74.x so I didn't notice it, and depended on the CdsLb changes so was causing the test failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/430347751 shows multiple concerning behaviors in the xDS stack with
the new A74 config update model. XdsDepManager and CdsLB2 still seem to
be working correctly, but the change is exacerbated issues in other
parts of the stack, like RingHashConfig not having equals fixed in
a8de9f0.
Revert only for the v1.74.x release, leaving it on master.
These commits will be kept separate when merging to v1.74.x