Repository navigation
build: Stop skipping codegen for HEAD^ in android.sh - #13184
Open
kannanjgithub wants to merge 1 commit into
Open
kannanjgithub wants to merge 1 commit into
kannanjgithub wants to merge 1 commit into
Conversation
The -PskipCodegen=true flag was a temporary workaround when upgrading Protobuf C++ to 22.5 (46485c8). Keeping it causes version-bump PRs to fail when building examples/android/helloworld on HEAD^ because the previous version's protoc-gen-grpc-java artifact is not published to Maven Local. TAG=agy CONV=cda9a2c8-e0c1-4c1a-a98e-51673d8e3c57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -PskipCodegen=true flag was a temporary workaround when upgrading Protobuf C++ to 22.5 (46485c8). Keeping it causes version-bump PRs to fail when building examples/android/helloworld on HEAD^ because the previous version's protoc-gen-grpc-java artifact is not published to Maven Local.