Partially revert "core: change serverimpl,servercallimpl's internalcl… #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose to cancel stream (grpc#4038)" This partially reverts commit 48ca452. It leaves the changes to ServerCallImpl and test. This also partially reverts "Lint fixes" commit 3002a23 which removed unused variables which are now necessary again. This is reverted for the combined result of two issues: * Some users are testing that they get UNKNOWN when the service throws. That's not unreasonable given the behavior was well-publicised when it changed in v1.5. We should probably keep the UNKNOWN in some common cases (like the service threw immediately, before sending anything). * The client could see CANCELLED instead of INTERNAL as had been intended. It's unclear as to why (I didn't investigate heavily). This behavior is visible in MoreInProcessTest and was overlooked during review.
zhangkun83
approved these changes
Mar 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ose to cancel stream (#4038)"
This partially reverts commit 48ca452.
It leaves the changes to ServerCallImpl and test.
This also partially reverts "Lint fixes" commit
3002a23 which removed unused variables
which are now necessary again.
This is reverted for the combined result of two issues:
That's not unreasonable given the behavior was well-publicised when it
changed in v1.5. We should probably keep the UNKNOWN in some common
cases (like the service threw immediately, before sending anything).
intended. It's unclear as to why (I didn't investigate heavily). This
behavior is visible in MoreInProcessTest and was overlooked during
review.
CC @ramaraochavali
This unfixes #3746, but since it hadn't been closed it doesn't need to be reopened.