Update min version of grpc-swift to fix static Linux SDK build #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Mar 17, 2025
|
Yes I wasn't sure this would be needed. But is it possible SPM resolves to the version without the patch when you're trying to build with the static SDK? I thought updating the version here would remove that possibility altogether. |
|
It's possible if there's an additional constraint in the dependency graph to limit the version of grpc-swift but that would also be problematic if we bumped the version here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/grpc/grpc-swift/releases/tag/2.1.1 fixes an issue that made
grpc-swiftnot compile using the static Linux SDK. This caused issues when trying to buildgrpc-swift-nio-transportusing the static Linux SDK. This PR updates the minimumgrpc-swiftversion to make it build successfully.