Skip to content

Conversation

@aybe
Copy link
Contributor

@aybe aybe commented Nov 7, 2025

Before:

image

After:

image

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Walkthrough

FileDialog rendering now displays full filenames with extensions for directory entries, derived from node->Path.filename().u8string() instead of the previously used stem-based approach, which stripped file extensions from the displayed labels.

Changes

Cohort / File(s) Summary
FileDialog display label rendering
third_party/ImFileDialog/ImFileDialog.cpp
Changed displayName derivation from node->Path.stem().u8string() (filename without extension) to node->Path.filename().u8string() (full filename with extension), altering how directory entries are labeled in the file dialog UI

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-line logic change affecting display label generation
  • Clear, straightforward modification with no control flow complexity
  • No public API or exported entity changes

Poem

🐰 A whisker-twitch of filename cheer,
Extensions now appear clear!
No more stems to hide the name,
Full filenames take the stage with fame.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: rendering directory nodes with full names including extensions instead of just stems.
Description check ✅ Passed The description is related to the changeset, providing visual before/after comparison images that illustrate the extension rendering change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47d83a2 and b13b80c.

📒 Files selected for processing (1)
  • third_party/ImFileDialog/ImFileDialog.cpp (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: pcsx-redux (aarch64-linux)
  • GitHub Check: pcsx-redux (x86_64-linux)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: toolchain
  • GitHub Check: macos-build-and-test-toolchain
  • GitHub Check: build
  • GitHub Check: coverage
  • GitHub Check: build-openbios
  • GitHub Check: cross-arm64
  • GitHub Check: asan
🔇 Additional comments (1)
third_party/ImFileDialog/ImFileDialog.cpp (1)

1075-1075: LGTM! Excellent consistency improvement.

The change from .stem() to .filename() correctly displays the full directory name including any extension. This makes the tree view consistent with the content view (lines 1125, 1184), selection logic (lines 597, 606), and other display contexts throughout the file. Directories with extensions (e.g., .app bundles, .git directories) will now render properly in the tree.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nicolasnoble nicolasnoble merged commit 1d573ef into grumpycoders:main Nov 13, 2025
21 of 22 checks passed
@aybe aybe deleted the fix-missing-directory-extension branch November 13, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants