add missing permission

[gcagle3]

Small PR to add missing permissions to our documentation.

Summary by CodeRabbit

• Documentation
  • Updated drift remediation guide to include AWS Step Functions read-only permission to validate state machine definitions, ensuring plan-role has required read-only access.
  • Clarified and corrected the permissions guidance for plan-role setup (typo fixed) so the listed Step Functions operations accurately reflect required coverage.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Ready	Preview	Comment	Aug 29, 2025 9:42pm

[coderabbitai]

Walkthrough

Documentation update adds states:ValidateStateMachineDefinition to the StatesReadOnlyAccess actions list and inserts a trailing comma; also fixes a minor typo. Changes are documentation/IAM-declaration only; no runtime logic altered.

Changes

Cohort / File(s)	Summary
Docs & IAM declaration docs/2.0/docs/accountfactory/guides/drift-remediation-with-async-module.md, \_envcommon/landingzone/root-pipelines-plan-role.hcl	Added states:ValidateStateMachineDefinition to the StatesReadOnlyAccess actions list and inserted a trailing comma after states:GetExecutionHistory. Fixed a typo ("at leasat" → "at least") in the docs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• include iam adjustment examples #2709 — Modifies the same StatesReadOnlyAccess IAM block; closely related change set.
• guide on using the new control-tower-multi-account-factory-async module #2701 — Edits the same drift-remediation-with-async-module documentation and Step Functions permissions.

Suggested reviewers

• odgrim
• ZachGoldberg

Poem

A tiny comma, a permission new,
Step Functions nod — the docs review.
Definitions checked, the change is small,
Drift kept tidy, standing tall.
Quiet fix, but right for all.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8c08ac1 and 0ad9ab7.

📒 Files selected for processing (1)

• docs/2.0/docs/accountfactory/guides/drift-remediation-with-async-module.md (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• docs/2.0/docs/accountfactory/guides/drift-remediation-with-async-module.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: validate_build
• GitHub Check: Pull Request has non-contributor approval
• GitHub Check: Validate generated content

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch account-factory-drift-detection-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

docs/2.0/docs/accountfactory/guides/drift-remediation-with-async-module.md (1)

137-137: Fix typo: “leasat” → “least”.

User-facing docs—please correct the spelling.

-For `_envcommon/landingzone/root-pipelines-plan-role.hcl`, ensure that you have at leasat the following permissions:
+For `_envcommon/landingzone/root-pipelines-plan-role.hcl`, ensure that you have at least the following permissions:

🧹 Nitpick comments (2)

docs/2.0/docs/accountfactory/guides/drift-remediation-with-async-module.md (2)

109-109: Minor grammar tweak for readability.

Add “to be” for smoother flow.

-The new infrastructure created by the async module will require additional permissions be added to the roles
+The new infrastructure created by the async module will require additional permissions to be added to the roles

---

173-183: Optional: call out KMS decrypt nuance for DescribeStateMachine.

If any state machine definitions are KMS-encrypted, read paths (e.g., DescribeStateMachine with ALL_DATA) may require kms:Decrypt. Consider adding a short note after this block to reduce surprises for readers.

Proposed note to insert after the code block:

+Note: If your Step Functions state machine definitions are encrypted with AWS KMS, the plan role may also need `kms:Decrypt` when reading definitions (e.g., DescribeStateMachine with ALL_DATA). See AWS docs for details.

Reference: AWS Step Functions DescribeStateMachine docs. (docs.aws.amazon.com)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b95f1ca and 8c08ac1.

📒 Files selected for processing (1)

• docs/2.0/docs/accountfactory/guides/drift-remediation-with-async-module.md (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Validate generated content

🔇 Additional comments (1)

docs/2.0/docs/accountfactory/guides/drift-remediation-with-async-module.md (1)

176-180: Good add: include ValidateStateMachineDefinition in read-only set.

states:ValidateStateMachineDefinition is a valid Step Functions read action and belongs in this block. This aligns with AWS docs. (docs.aws.amazon.com)