This repository was archived by the owner on Feb 29, 2024. It is now read-only.
메이븐 설정 추가 및 유닛 테스트 6가지 추가 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommonHttpServer class 를 테스트하기위한 클래스 2개 추가 CommonHttpServerTestCase : CommonHttpServer 를 테스트하기위해 반복적으로 사용되거나 가독성 및 반복되는 코드를 줄이기위한 상위 클래스 TestCommonHttpServer : 간단하게 200, 404, servlet, filter, global filter 테스트
로컬 임시 주키퍼 서버인 ZookeeperLocalServer 추가. 제대로 한 것인지는 불분명 :-)
변경 TestCommonHttpServer : testZookeeperServlet 테스트 메서드를 TestZKManagerWebServer 로 이동 (http 밑에 있어서 http 에 뒀는데 zk 에 있길래 위치 변경)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
상세한 것은 커밋로그보시면 될 것 같아요. 근데 pull request 를 해본적이 없어서 이게 맞나 모르겠네요.
재미삼아 분석 중인데 제가 코드 퀄리티 떨어뜨리는거 아닌지 모르겠네요 ㅋㅋㅋ 알맞게 고치셔도 될 듯요.
이전 두번은 close 해버렸는데, 이번엔 close 하지 않고 해봐야겠네요.