TC-5399: Add helm-unittest CI integration to GitHub Actions workflow - #101
TC-5399: Add helm-unittest CI integration to GitHub Actions workflow#101chetna14manku wants to merge 1 commit into
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR extends the existing GitHub Actions lint/test workflow by adding a dedicated job that installs Helm, sets up the helm-unittest plugin, and runs unit tests for the Trustify chart as part of CI. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a
needs: lint-testor similar dependency so theunittestjob runs in a predictable sequence relative to the existing lint job and avoids unnecessary parallel runs. - You may want to reuse the Helm setup from the existing jobs (e.g., via a reusable workflow or shared step) to avoid duplicating the
setup-helmconfiguration and version pinning. - Review whether
--verify=falseis actually required for thehelm-unittestplugin install; if not, dropping it would keep the plugin verification behavior aligned with security best practices.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a `needs: lint-test` or similar dependency so the `unittest` job runs in a predictable sequence relative to the existing lint job and avoids unnecessary parallel runs.
- You may want to reuse the Helm setup from the existing jobs (e.g., via a reusable workflow or shared step) to avoid duplicating the `setup-helm` configuration and version pinning.
- Review whether `--verify=false` is actually required for the `helm-unittest` plugin install; if not, dropping it would keep the plugin verification behavior aligned with security best practices.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0f69d88 to
0687af4
Compare
|
hi @chetna14manku thanks for the PR. Question: Why to use a different branch instead of
|
.....
Hi @helio-frota Thank you for the review! |
|
@chetna14manku got it! thanks for the extra info 👍 |

Summary by Sourcery
CI: