Skip to content

TC-5399: Add helm-unittest CI integration to GitHub Actions workflow - #101

Open
chetna14manku wants to merge 1 commit into
guacsec:helm-unittests-covfrom
chetna14manku:TC-5399
Open

TC-5399: Add helm-unittest CI integration to GitHub Actions workflow#101
chetna14manku wants to merge 1 commit into
guacsec:helm-unittests-covfrom
chetna14manku:TC-5399

Conversation

@chetna14manku

@chetna14manku chetna14manku commented Aug 11, 2026

Copy link
Copy Markdown

Summary by Sourcery

CI:

  • Integrate helm-unittest into the GitHub Actions lint-test workflow as a separate unittest job that sets up Helm, installs the plugin, and executes chart unit tests.

@sourcery-ai

sourcery-ai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR extends the existing GitHub Actions lint/test workflow by adding a dedicated job that installs Helm, sets up the helm-unittest plugin, and runs unit tests for the Trustify chart as part of CI.

File-Level Changes

Change Details Files
Add a helm-unittest job to the GitHub Actions lint-test workflow to run Helm chart unit tests in CI.
  • Introduce a new 'unittest' job in the workflow that runs on ubuntu-latest.
  • Check out the repository source using the latest v4.2.2 version of actions/checkout.
  • Install Helm using azure/setup-helm with a pinned Helm version v3.13.3.
  • Install the helm-unittest plugin at version v1.1.2 with verification disabled.
  • Execute helm unittest with --failfast against the charts/trustify directory to run Trustify chart unit tests.
.github/workflows/lint-test.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding a needs: lint-test or similar dependency so the unittest job runs in a predictable sequence relative to the existing lint job and avoids unnecessary parallel runs.
  • You may want to reuse the Helm setup from the existing jobs (e.g., via a reusable workflow or shared step) to avoid duplicating the setup-helm configuration and version pinning.
  • Review whether --verify=false is actually required for the helm-unittest plugin install; if not, dropping it would keep the plugin verification behavior aligned with security best practices.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a `needs: lint-test` or similar dependency so the `unittest` job runs in a predictable sequence relative to the existing lint job and avoids unnecessary parallel runs.
- You may want to reuse the Helm setup from the existing jobs (e.g., via a reusable workflow or shared step) to avoid duplicating the `setup-helm` configuration and version pinning.
- Review whether `--verify=false` is actually required for the `helm-unittest` plugin install; if not, dropping it would keep the plugin verification behavior aligned with security best practices.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chetna14manku
chetna14manku force-pushed the TC-5399 branch 2 times, most recently from 0f69d88 to 0687af4 Compare August 11, 2026 08:24
@chetna14manku
chetna14manku changed the base branch from main to helm-unittests-cov August 11, 2026 11:24
@helio-frota

Copy link
Copy Markdown
Contributor

hi @chetna14manku thanks for the PR.
I'm not familiar with this kind of tests but they are running-and-passing...

### Chart [ trustify ] charts/trustify

 PASS  importer proxy env vars	charts/trustify/tests/importer_deployment_test.yaml
 PASS  server cacheTTL	charts/trustify/tests/server_deployment_test.yaml

Charts:      1 passed, 1 total
Test Suites: 2 passed, 2 total
Tests:       7 passed, 7 total
Snapshot:    0 passed, 0 total
Time:        1.309664941s

Question: Why to use a different branch instead of main ?

2026-08-13_11-31

@chetna14manku

Copy link
Copy Markdown
Author

hi @chetna14manku thanks for the PR. I'm not familiar with this kind of tests but they are running-and-passing...

.....

Question: Why to use a different branch instead of main ?

Hi @helio-frota Thank you for the review!
We're using a separate branch to add all the required test cases (tracked in TC-5398) to ensure these new changes don't break anything on main. Once the full suite is complete and verified, we will merge it into main.

@helio-frota

Copy link
Copy Markdown
Contributor

@chetna14manku got it! thanks for the extra info 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants