Skip to content

chore: add callback URL for swagger-ui [Backport release/0.5.z] - #2517

Open
trustify-ci-bot[bot] wants to merge 1 commit into
release/0.5.zfrom
backport-2514-to-release/0.5.z
Open

chore: add callback URL for swagger-ui [Backport release/0.5.z]#2517
trustify-ci-bot[bot] wants to merge 1 commit into
release/0.5.zfrom
backport-2514-to-release/0.5.z

Conversation

@trustify-ci-bot

@trustify-ci-bot trustify-ci-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Description

Backport of #2514 to release/0.5.z.

Summary by Sourcery

Enhancements:

  • Extend allowed callback URLs for the frontend Cognito client to include the Swagger UI OAuth2 redirect endpoint in the Trustify SSO example.

@sourcery-ai

sourcery-ai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Backports a configuration update to include the Swagger UI OAuth redirect URL in the Cognito user pool client's callback URLs for the admin Trustify SSO example.

Sequence diagram for Swagger UI OAuth redirect callback URL

sequenceDiagram
    actor AdminUser
    participant Browser
    participant SwaggerUI
    participant CognitoUserPoolClient

    AdminUser->>Browser: Open SwaggerUI
    Browser->>SwaggerUI: Request /swagger-ui
    SwaggerUI->>CognitoUserPoolClient: Start OAuth flow
    CognitoUserPoolClient-->>Browser: Redirect to login
    Browser->>CognitoUserPoolClient: Submit credentials
    CognitoUserPoolClient-->>Browser: Redirect to swagger-ui/oauth2-redirect.html
    Browser->>SwaggerUI: Call oauth2-redirect.html with auth code
    SwaggerUI->>CognitoUserPoolClient: Exchange code for token
Loading

File-Level Changes

Change Details Files
Add Swagger UI OAuth redirect URL to Cognito app client callback URLs.
  • Extend the callback_urls list for the aws_cognito_user_pool_client frontend resource to include the swagger-ui OAuth2 redirect path under the console URL
docs/book/modules/admin/examples/trustify/sso.tf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ctron

ctron commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This is documentation, we don't need to backport that IIRC.

@matejnesuta

Copy link
Copy Markdown

Hello Jens, I marked it as a backport, as QE uses these config files to setup AWS services for TPA testing.

@ctron

ctron commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

We normally don't backport doc changes. I this automatically consumed from this branch? Or just from main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants