-
Notifications
You must be signed in to change notification settings - Fork 48
fix(purl): add VersionMatches filter to product status query [Backport release/0.4.z] #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ruromero
wants to merge
4
commits into
guacsec:release/0.4.z
Choose a base branch
from
ruromero:backport-2521-to-release/0.4.z
base: release/0.4.z
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−6
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
57e47b4
fix(purl): add VersionMatches filter to product status query
ruromero 9b3312c
test(purl): add product_status path version filtering test
ruromero 1faf3a3
fix(test): adapt product_status_version_filtering test for release/0.4.z
ruromero 493af3b
fix(clippy): remove redundant references in format! arguments
ruromero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (testing): Add a complementary negative test to ensure non-affected or non-RPM PURLs do not get product_status entries
This test verifies that affected RPM PURLs produce
product_statusentries with aversion_range, but it doesn’t cover the false positives described in the PR (e.g., non-RPM packages or already-fixed versions still showing as affected).To better protect against regressions, please add at least one negative-path test, such as:
product_statusentries are returned.product_statusmatches.These tests will directly validate that
VersionMatchesblocks the false positives mentioned in the PR and tighten regression coverage.