Set the toggle to true on New Account Review #3111
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinsola-guardian
requested review from
guardian-ci
and removed request for
guardian-ci
coldlink
reviewed
Mar 19, 2025
| @@ -86,7 +86,7 @@ describe('New account review page', () => { | |||
| expect(consent.consented).to.be.true; | |||
| } | |||
| if (consent.id === 'personalised_advertising') { | |||
| expect(consent.consented).to.be.true; | |||
| expect(consent.consented).to.be.false; | |||
There was a problem hiding this comment.
This was fine as it was.
The problem is on line 66 of the test file, where we click on the advertising checkbox.
With the change in this PR, we don't need that click anymore, as advertising is on by default, and we click to turn it off, whereas before advertising was off by default and we had to click to turn it on.
So we should remove this click, and update the comment
Suggested change
| expect(consent.consented).to.be.false; | |
| expect(consent.consented).to.be.true; |
akinsola-guardian
force-pushed
the
al-set-new-account-review-toggle-true
branch
from
a4a4d97 to
594f217
Compare
akinsola-guardian
requested review from
guardian-ci
and removed request for
guardian-ci
akinsola-guardian
force-pushed
the
al-set-new-account-review-toggle-true
branch
from
594f217 to
f161416
Compare
coldlink
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Shows the advertisng and profiling sections by default for non ad-free users.
How to test
Tested in CODE.