Run OrbotService and TorService in single process#1666
Open
syphyr wants to merge 1 commit intoguardianproject:masterfrom
Open
Run OrbotService and TorService in single process#1666syphyr wants to merge 1 commit intoguardianproject:masterfrom
syphyr wants to merge 1 commit intoguardianproject:masterfrom
Conversation
When using power user mode and not setting battery optimization exemption, this helps Orbot from being killed by Android for the following reasons: 1. Reduces memory footprint (one process instead of two) 2. Makes the service appear as a single, larger component to the OS 3. Eliminates the overhead of inter-process communication Android's process killer considers: - Total memory usage - Number of active processes - Process importance (foreground vs background) By combining: - You halve the process count - The unified service can more easily maintain foreground priority - The OS sees one "important" service rather than two separate ones
Contributor
Author
|
Consider the following test case:
Orbot no longer gets killed by Android when OrbotService and TorService run in a single process in this test case. Maybe because of the change in inter-process communication? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using power user mode and not setting battery optimization exemption (may drain the battery), this helps Orbot from being killed by Android for the following reasons:
Android's process killer considers:
By combining: