-
Notifications
You must be signed in to change notification settings - Fork 730
Fixes #4391. Weird situation where ForceDriver with args doesn't persists on open scenario #4395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2_develop
Are you sure you want to change the base?
Conversation
…t persists on open scenario
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2_develop #4395 +/- ##
===========================================
Coverage 74.56% 74.56%
===========================================
Files 388 388
Lines 46568 46585 +17
Branches 6548 6550 +2
===========================================
+ Hits 34723 34736 +13
- Misses 9993 9996 +3
- Partials 1852 1853 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…ing also initialize with driver instead of only by driver name.
|
I really shouldn't have asked to make this testable. Sorry about all the trouble and complexity it caused. The fix is clear and obvious. If you're ok with pulling out all the test stuff I'd be ok with that. |
No problem, we only arrive at some conclusion and experience through doing it.
If you're referring to creating the Run method in the UICatalog class and its unit test, I can remove that code. In fact, simply adding a Debug.Assertion of the current driver before and after opening a scenario in UICatalog is sufficient to verify that it's correct. |
This reverts commit 2bd7cd7.
Fixes
Proposed Changes/Todos
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)