Add support for explicit mode-by-mode waveform generators#5230
Draft
acorreia61201 wants to merge 32 commits intogwastro:masterfrom
Draft
Add support for explicit mode-by-mode waveform generators#5230acorreia61201 wants to merge 32 commits intogwastro:masterfrom
acorreia61201 wants to merge 32 commits intogwastro:masterfrom
Conversation
…ure marg phase class to inherit from BaseGatedGaussian
…n new class to models init, waveform modes models to generator
…ent with other models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds generators for generating the ringdown models mode-by-mode, as well as allowing for multimodal waveform plugins that explicitly calculate individual modes to be generated in the same way.
Earlier iterations of PR #5229 attempted to calculate likelihoods by generating templates as individual modes (e.g. QNM approximants). The current iteration of that PR no longer requires these changes; however, I've kept them here in case they end up being useful in the future.