Draft
Conversation
Adding single ifo effective distance and cuadrature
Adding "mollweide" projection for injections in the sky
Comment on lines
+219
to
+220
| 'eff_site_dist', 'eff_dist', 'eff_dist_H1', | ||
| 'eff_dist_L1', 'eff_dist_V1', 'eff_dist_sqr_quadsum', |
Contributor
There was a problem hiding this comment.
Note that we already have "eff_site_dist" to plot the effective distance for a specific site. What is the motivation for adding the explicit per-site ones?
Comment on lines
+462
to
+464
| ax = fig.add_subplot(111, projection="mollweide") | ||
| missed_inj['ra'] = ra_to_ra_mollweide(missed_inj['ra']) | ||
| found_inj['ra'] = ra_to_ra_mollweide(found_inj['ra']) |
Contributor
There was a problem hiding this comment.
There are some cases where the all-sky projection plot is detrimental, typically when the input skymap is very precise, as all points are bunched together into a single blob. Perhaps we could have different variable names to control the projection, e.g. "ra"/"dec" and "ra_mollweide"/"dec_mollweide". Another way (probably my preferred one actually) would be to add a command line argument like --sky-projection mollweide that is only used when "ra" and "dec" are being plotted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a: new feature
This change affects: PyGRB
This change changes: result presentation / plotting.
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: break current functionality, require additional dependencies, require a new release, other (please describe)
Motivation
This PR is still a draft.
It adds further capabilities for the plot_injs_results script related to single ifo effective distances. Additionally adds the "mollweide" projection to display the injections in the sky plane.