Generalize time-domain waveform modes generation via lalsim#5245
Open
prayush wants to merge 1 commit intogwastro:masterfrom
Open
Generalize time-domain waveform modes generation via lalsim#5245prayush wants to merge 1 commit intogwastro:masterfrom
prayush wants to merge 1 commit intogwastro:masterfrom
Conversation
* Added a function to generate waveform modes for many time-domain approximants available via lalsimulation. * Added a function to generate lalsimulation approximant object from model name string.
Member
|
@prayush You'll need to rebase before we can merger, but a couple questions. (1) Is the hard coded lmax ok here? (2) Are there issues with convention compatibility (especially for precessing models) across the approximants or is this now largely consistent? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalize time-domain waveform modes generation via lalsim
Users can generate waveform multipoles for surrogate models currently, but not for many others. It would be useful to have modes from other approximants available as well. This PR enables that.
Added a function to generate waveform modes for many time-domain approximants available via lalsimulation.
Added a function to generate lalsimulation approximant object from model name string.
Standard information about the request
This is a: feature update, with complete backward compatibility
This change affects: None
This change changes: waveform generation
This change: follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: NOT break current functionality, NOT require additional dependencies.